Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make button styles more consistent #9264

Closed
wants to merge 2 commits into from
Closed

Make button styles more consistent #9264

wants to merge 2 commits into from

Conversation

Etheryte
Copy link
Member

@Etheryte Etheryte commented Sep 10, 2024 •
edited
Loading

What does this PR change?

Make buttons styles more uniform, fix hover border bugs, etc.

GUI diff

Button styles updated.

Screenshot 2024-09-10 at 18 36 00 Screenshot 2024-09-10 at 18 50 22
  • DONE

Documentation

  • Docs issue already exists.

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: style updates

  • DONE

Links

Part of https://github.com/SUSE/spacewalk/issues/18940

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@github-actions GitHub Actions
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9264/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9264/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@Etheryte Etheryte marked this pull request as ready for review September 10, 2024 15:54
@Etheryte Etheryte requested a review from a team as a code owner September 10, 2024 15:54
bisht-richa
bisht-richa approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@bisht-richa bisht-richa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Etheryte
Copy link
Member Author

Etheryte commented Nov 8, 2024

Superseded by the other branch that works with buttons, we can revisit this later if need be.

@Etheryte Etheryte closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisht-richa bisht-richa bisht-richa approved these changes

Assignees
No one assigned
Labels
javascript_lint ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Etheryte @bisht-richa